-
Notifications
You must be signed in to change notification settings - Fork 4
Add zksync os setup in CI #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LCOV Report ✅All Files
Changed FilesN/A |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds CI support for testing against zkSync OS by introducing configurable chain ID and RPC port parameters. The changes enable the same integration test suite to run against both the standard Anvil environment (chain ID 1337, port 8545) and zkSync OS (chain ID 6565, port 3050).
Key Changes:
- Introduced environment-configurable
chainId()andrpcPort()helper functions to support multiple test environments - Added new GitHub Actions workflow job to test against zkSync OS infrastructure
- Updated timeout values from 0 (infinite) to 2,000ms across tests for more predictable CI behavior
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| test/integration/utils.ts | Added chainId() and rpcPort() helper functions, updated contractAddresses() to use dynamic chain ID, modified localhost chain ID dynamically, increased timeout from 100ms to 2,000ms |
| test/integration/passkey.test.ts | Replaced hardcoded anvilPort with rpcPort() call, updated timeout from 0 to 2,000ms, replaced hardcoded chain ID 1337 with chainId() |
| test/integration/basic.test.ts | Replaced hardcoded anvilPort with rpcPort() call, updated timeout from 0 to 2,000ms, replaced hardcoded chain ID 1337 with chainId(), reduced paymaster deposit from 1 ETH to 0.1 ETH |
| test/integration/account.ts | Imported and used chainId() to replace hardcoded chain ID values in user operation and typed data signing |
| package.json | Added bundler:zksync-os, test:zksync-os, and deploy-test:zksync-os scripts for zkSync OS testing |
| alto-zksync-os.json | New bundler configuration for zkSync OS with appropriate RPC URL and private keys |
| .github/workflows/ci.yaml | New zksync-os job that sets up zkSync OS server, deploys contracts, and runs integration tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.