Skip to content

Conversation

@ly0va
Copy link
Member

@ly0va ly0va commented Dec 1, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

LCOV Report ✅

All Files

  • Lines: 556/715 (77.8%) ✅ (Minimum coverage is 0%)
  • Functions: 118/136 (86.8%)
  • Branches: 86/245 (35.1%)

Changed Files

N/A

@ly0va ly0va marked this pull request as ready for review December 1, 2025 23:11
@ly0va ly0va requested a review from cpb8010 December 1, 2025 23:13
@cpb8010 cpb8010 requested a review from Copilot December 1, 2025 23:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds CI support for testing against zkSync OS by introducing configurable chain ID and RPC port parameters. The changes enable the same integration test suite to run against both the standard Anvil environment (chain ID 1337, port 8545) and zkSync OS (chain ID 6565, port 3050).

Key Changes:

  • Introduced environment-configurable chainId() and rpcPort() helper functions to support multiple test environments
  • Added new GitHub Actions workflow job to test against zkSync OS infrastructure
  • Updated timeout values from 0 (infinite) to 2,000ms across tests for more predictable CI behavior

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
test/integration/utils.ts Added chainId() and rpcPort() helper functions, updated contractAddresses() to use dynamic chain ID, modified localhost chain ID dynamically, increased timeout from 100ms to 2,000ms
test/integration/passkey.test.ts Replaced hardcoded anvilPort with rpcPort() call, updated timeout from 0 to 2,000ms, replaced hardcoded chain ID 1337 with chainId()
test/integration/basic.test.ts Replaced hardcoded anvilPort with rpcPort() call, updated timeout from 0 to 2,000ms, replaced hardcoded chain ID 1337 with chainId(), reduced paymaster deposit from 1 ETH to 0.1 ETH
test/integration/account.ts Imported and used chainId() to replace hardcoded chain ID values in user operation and typed data signing
package.json Added bundler:zksync-os, test:zksync-os, and deploy-test:zksync-os scripts for zkSync OS testing
alto-zksync-os.json New bundler configuration for zkSync OS with appropriate RPC URL and private keys
.github/workflows/ci.yaml New zksync-os job that sets up zkSync OS server, deploys contracts, and runs integration tests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ly0va ly0va merged commit 03f2cea into main Dec 2, 2025
18 checks passed
@ly0va ly0va deleted the lyova-zksyncos-ci branch December 2, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants